Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: use local isolate instead of args.GetIsolate
While stepping though SetupPromises I noticed that the environments Isolate is used but not when creating the string "_setupPromises". Is there a reason for using args.GetIsolate() instead of using the environments isolate? I see that GetIsolate() is an inline call, but could there be situations where it returns a different Isolate? If not perhaps using the local isolate variable would be a litte clearer. PR-URL: #14768 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
- Loading branch information