Skip to content

Commit

Permalink
build,deps: use PCH also for v8_initializers
Browse files Browse the repository at this point in the history
* rename files to represent reuse

PR-URL: #25931
Reviewed-By: João Reis <reis@janeasystems.com>
refack committed Feb 14, 2019
1 parent 82b7989 commit cd5c7bf
Showing 5 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',

##### V8 defaults for Node.js #####

23 changes: 14 additions & 9 deletions deps/v8/gypfiles/v8.gyp
Original file line number Diff line number Diff line change
@@ -222,7 +222,7 @@
'dependencies': [
'v8_base',
],
'variables': {
'variables': {
'optimize': 'max',
},
'include_dirs': [
@@ -359,16 +359,20 @@
}],
# Platforms that don't have Compare-And-Swap support need to link atomic
# library to implement atomic memory access
[ 'v8_current_cpu == "mips" or v8_current_cpu == "mipsel" or '
'v8_current_cpu == "mips64" or v8_current_cpu == "mips64el" or '
'v8_current_cpu == "ppc" or v8_current_cpu == "ppc64" or '
'v8_current_cpu == "s390" or v8_current_cpu == "s390x"',
{
[ 'v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "ppc64", "s390", "s390x"]', {
'link_settings': {
'libraries': [ '-latomic', ],
},
},
],
['OS=="win" and node_use_pch == "true"', {
'msvs_precompiled_header': '../../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '../../../tools/msvs/pch/v8_pch.cc',
'sources': [
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
],
}],
],
}, # v8_initializers
{
@@ -1942,10 +1946,11 @@
# See http://crbug.com/485155.
'msvs_shard': 4,
}, {
'msvs_precompiled_header': 'tools/msvs/pch/pch_v8_base.h',
'msvs_precompiled_source': '../../../tools/msvs/pch/pch_v8_base.cc',
'msvs_precompiled_header': '../../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '../../../tools/msvs/pch/v8_pch.cc',
'sources': [
'../../../tools/msvs/pch/pch_v8_base.cc',
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
],
}],
],
1 change: 0 additions & 1 deletion tools/msvs/pch/pch_v8_base.cc

This file was deleted.

1 change: 1 addition & 0 deletions tools/msvs/pch/v8_pch.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "v8_pch.h"
File renamed without changes.

0 comments on commit cd5c7bf

Please sign in to comment.