Skip to content

Commit

Permalink
fs: remove unnecessary bind
Browse files Browse the repository at this point in the history
Don't use Function.prototype.bind where it isn't
necessary. Rely on event emitter context instead
and on arrow function as class property.

PR-URL: #28131
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
apapirovski authored and BethGriggs committed Feb 6, 2020
1 parent 25ba7f4 commit cc9712d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions lib/internal/fs/promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class FileHandle {
return writeFile(this, data, options);
}

close() {
close = () => {
return this[kHandle].close();
}
}
Expand Down Expand Up @@ -411,7 +411,7 @@ async function lchmod(path, mode) {
throw new ERR_METHOD_NOT_IMPLEMENTED('lchmod()');

const fd = await open(path, O_WRONLY | O_SYMLINK);
return fchmod(fd, mode).finally(fd.close.bind(fd));
return fchmod(fd, mode).finally(fd.close);
}

async function lchown(path, uid, gid) {
Expand Down Expand Up @@ -476,7 +476,7 @@ async function writeFile(path, data, options) {
return writeFileHandle(path, data, options);

const fd = await open(path, flag, options.mode);
return writeFileHandle(fd, data, options).finally(fd.close.bind(fd));
return writeFileHandle(fd, data, options).finally(fd.close);
}

async function appendFile(path, data, options) {
Expand All @@ -494,7 +494,7 @@ async function readFile(path, options) {
return readFileHandle(path, options);

const fd = await open(path, flag, 0o666);
return readFileHandle(fd, options).finally(fd.close.bind(fd));
return readFileHandle(fd, options).finally(fd.close);
}

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/fs/streams.js
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ WriteStream.prototype.close = function(cb) {
// If we are not autoClosing, we should call
// destroy on 'finish'.
if (!this.autoClose) {
this.on('finish', this.destroy.bind(this));
this.on('finish', this.destroy);
}

// We use end() instead of destroy() because of
Expand Down

0 comments on commit cc9712d

Please sign in to comment.