From cc607b1176013a16866e264a12a93a9ec72120af Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 13 Sep 2016 11:38:55 -0700
Subject: [PATCH] test: add coverage for client._addHandle()

`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: https://github.com/nodejs/node/pull/8518
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 .../test-debugger-client-addhandle.js         | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 test/parallel/test-debugger-client-addhandle.js

diff --git a/test/parallel/test-debugger-client-addhandle.js b/test/parallel/test-debugger-client-addhandle.js
new file mode 100644
index 00000000000000..bb953561b945a9
--- /dev/null
+++ b/test/parallel/test-debugger-client-addhandle.js
@@ -0,0 +1,44 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const Client = require('_debugger').Client;
+
+{
+  const client = new Client();
+  assert.deepStrictEqual(client.handles, {});
+}
+
+{
+  const client = new Client();
+  client._addHandle(null);
+  assert.deepStrictEqual(client.handles, {});
+}
+
+{
+  const client = new Client();
+  client._addHandle('not an object');
+  assert.deepStrictEqual(client.handles, {});
+}
+
+{
+  const client = new Client();
+  client._addHandle({ handle: 'not a number' });
+  assert.deepStrictEqual(client.handles, {});
+}
+
+{
+  const client = new Client();
+  const validNoScript = { handle: 6, id: 'foo', type: 'not a script' };
+  client._addHandle(validNoScript);
+  assert.deepStrictEqual(client.handles, { 6: validNoScript });
+  assert.deepStrictEqual(client.scripts, {});
+}
+
+{
+  const client = new Client();
+  const validWithScript = { handle: 5, id: 'bar', type: 'script' };
+  client._addHandle(validWithScript);
+  assert.deepStrictEqual(client.handles, { 5: validWithScript });
+  assert.deepStrictEqual(client.scripts, { bar: validWithScript });
+}