From bd3a9f464b2010b44fc160cfd8ace3e505c9cde3 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 11 Aug 2020 16:09:29 +0200 Subject: [PATCH] test: fix test_worker_terminate_finalization The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in https://github.com/nodejs/node/pull/34625. PR-URL: https://github.com/nodejs/node/pull/34726 Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Ricky Zhou <0x19951125@gmail.com> --- .../test_worker_terminate_finalization.c | 1 - 1 file changed, 1 deletion(-) diff --git a/test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c b/test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c index 6171f01e1519eb..bb23830ecd2731 100644 --- a/test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c +++ b/test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c @@ -22,7 +22,6 @@ napi_value Test(napi_env env, napi_callback_info info) { size_t argc = 1; napi_value argv[1]; napi_value result; - napi_ref ref; void* bufferData = malloc(BUFFER_SIZE); NAPI_CALL(env, napi_get_cb_info(env, info, &argc, argv, NULL, NULL));