fs: consistently return symlink type from readdir

Use 'lstat' to determine type of directory entry. This is more consistent with the type returned from the readdir binding. Also use 'path.join' over 'path.resolve' because 'name' is not absolute. PR-URL: #22808 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Oct 3, 2018 · bb6530b · bb6530b
1 parent 074b7af
commit bb6530b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -131,7 +131,7 @@ function getDirents(path, [names, types], callback) {
         const name = names[i];
         const idx = i;
         toFinish++;
-        lazyLoadFs().stat(pathModule.resolve(path, name), (err, stats) => {
+        lazyLoadFs().lstat(pathModule.join(path, name), (err, stats) => {
           if (err) {
             callback(err);
             return;
@@ -154,7 +154,7 @@ function getDirents(path, [names, types], callback) {
       const type = types[i];
       if (type === UV_DIRENT_UNKNOWN) {
         const name = names[i];
-        const stats = lazyLoadFs().statSync(pathModule.resolve(path, name));
+        const stats = lazyLoadFs().lstatSync(pathModule.join(path, name));
         names[i] = new DirentFromStats(name, stats);
       } else {
         names[i] = new Dirent(names[i], types[i]);