fs: improve fsPromises writeFile performance

Increase the write chunk size in fsPromises writeFile to improve performance. PR-URL: #37610 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Mar 16, 2021 · ba91ef2 · ba91ef2
1 parent 2d9b624
commit ba91ef2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -6,7 +6,7 @@ const kIoMaxLength = 2 ** 31 - 1;
 
 const kReadFileBufferLength = 512 * 1024;
 const kReadFileUnknownBufferLength = 64 * 1024;
-const kWriteFileMaxChunkSize = 2 ** 14;
+const kWriteFileMaxChunkSize = 512 * 1024;
 
 const {
   ArrayPrototypePush,

diff --git a/test/parallel/test-fs-promises-file-handle-writeFile.js b/test/parallel/test-fs-promises-file-handle-writeFile.js
@@ -30,7 +30,7 @@ async function validateWriteFile() {
 async function doWriteAndCancel() {
   const filePathForHandle = path.resolve(tmpDir, 'dogs-running.txt');
   const fileHandle = await open(filePathForHandle, 'w+');
-  const buffer = Buffer.from('dogs running'.repeat(10000), 'utf8');
+  const buffer = Buffer.from('dogs running'.repeat(512 * 1024), 'utf8');
   const controller = new AbortController();
   const { signal } = controller;
   process.nextTick(() => controller.abort());