From b702ba350ff4ea43b1894ae436bc67d216040908 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 22 Feb 2018 02:52:05 +0100 Subject: [PATCH] [squash] extend test case --- .../test-http2-client-write-empty-string.js | 78 ++++++++++--------- 1 file changed, 42 insertions(+), 36 deletions(-) diff --git a/test/parallel/test-http2-client-write-empty-string.js b/test/parallel/test-http2-client-write-empty-string.js index 757dde906cbfc8..c10698d417038d 100644 --- a/test/parallel/test-http2-client-write-empty-string.js +++ b/test/parallel/test-http2-client-write-empty-string.js @@ -7,42 +7,48 @@ const common = require('../common'); if (!common.hasCrypto) common.skip('missing crypto'); -const server = http2.createServer(); -server.on('stream', common.mustCall((stream, headers, flags) => { - stream.respond({ 'content-type': 'text/html' }); - - let data = ''; - stream.on('data', common.mustNotCall((chunk) => { - data += chunk.toString(); - })); - stream.on('end', common.mustCall(() => { - stream.end(`"${data}"`); +for (const chunkSequence of [ + [ '' ], + [ '', '' ] +]) { + const server = http2.createServer(); + server.on('stream', common.mustCall((stream, headers, flags) => { + stream.respond({ 'content-type': 'text/html' }); + + let data = ''; + stream.on('data', common.mustNotCall((chunk) => { + data += chunk.toString(); + })); + stream.on('end', common.mustCall(() => { + stream.end(`"${data}"`); + })); })); -})); - -server.listen(0, common.mustCall(() => { - const port = server.address().port; - const client = http2.connect(`http://localhost:${port}`); - - const req = client.request({ - ':method': 'POST', - ':path': '/' - }); - req.on('response', common.mustCall((headers) => { - assert.strictEqual(headers[':status'], 200); - assert.strictEqual(headers['content-type'], 'text/html'); + server.listen(0, common.mustCall(() => { + const port = server.address().port; + const client = http2.connect(`http://localhost:${port}`); + + const req = client.request({ + ':method': 'POST', + ':path': '/' + }); + + req.on('response', common.mustCall((headers) => { + assert.strictEqual(headers[':status'], 200); + assert.strictEqual(headers['content-type'], 'text/html'); + })); + + let data = ''; + req.setEncoding('utf8'); + req.on('data', common.mustCallAtLeast((d) => data += d)); + req.on('end', common.mustCall(() => { + assert.strictEqual(data, '""'); + server.close(); + client.close(); + })); + + for (const chunk of chunkSequence) + req.write(chunk); + req.end(); })); - - let data = ''; - req.setEncoding('utf8'); - req.on('data', common.mustCallAtLeast((d) => data += d)); - req.on('end', common.mustCall(() => { - assert.strictEqual(data, '""'); - server.close(); - client.close(); - })); - - req.write(''); - req.end(); -})); +}