From b6001a2da5349de5eeddcc9e4cbcb930bfe6c29c Mon Sep 17 00:00:00 2001 From: cjihrig Date: Thu, 27 Apr 2017 18:26:17 -0400 Subject: [PATCH] src: make SIGPROF message a real warning This commit replaces a fprintf() with a call to ProcessEmitWarning(). Refs: https://github.com/nodejs/node/issues/12706 PR-URL: https://github.com/nodejs/node/pull/12709 Reviewed-By: Jeremiah Senkpiel Reviewed-By: Sam Roberts Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell Reviewed-By: Anna Henningsen --- src/signal_wrap.cc | 3 ++- test/parallel/test-warn-sigprof.js | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-warn-sigprof.js diff --git a/src/signal_wrap.cc b/src/signal_wrap.cc index ccd1b0ec411dc8..1af98a9311f102 100644 --- a/src/signal_wrap.cc +++ b/src/signal_wrap.cc @@ -92,7 +92,8 @@ class SignalWrap : public HandleWrap { if (signum == SIGPROF) { Environment* env = Environment::GetCurrent(args); if (env->inspector_agent()->IsStarted()) { - fprintf(stderr, "process.on(SIGPROF) is reserved while debugging\n"); + ProcessEmitWarning(env, + "process.on(SIGPROF) is reserved while debugging"); return; } } diff --git a/test/parallel/test-warn-sigprof.js b/test/parallel/test-warn-sigprof.js new file mode 100644 index 00000000000000..eedbe33d84ff2a --- /dev/null +++ b/test/parallel/test-warn-sigprof.js @@ -0,0 +1,17 @@ +'use strict'; +const common = require('../common'); + +// The inspector attempts to start when Node starts. Once started, the inspector +// warns on the use of a SIGPROF listener. + +common.skipIfInspectorDisabled(); + +if (common.isWindows) { + common.skip('test does not apply to Windows'); + return; +} + +common.expectWarning('Warning', + 'process.on(SIGPROF) is reserved while debugging'); + +process.on('SIGPROF', () => {});