Skip to content

Commit

Permalink
build: add benchmark tests to CI runs
Browse files Browse the repository at this point in the history
Closes: #34321

PR-URL: #34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
  • Loading branch information
Trott authored and ruyadorno committed Jul 29, 2020
1 parent fced3ce commit b24f254
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run a

# CI_* variables should be kept synchronized with the ones in vcbuild.bat
CI_NATIVE_SUITES ?= addons js-native-api node-api
CI_JS_SUITES ?= default
CI_JS_SUITES ?= default benchmark
ifeq ($(node_use_openssl), false)
CI_DOC := doctool
else
Expand Down Expand Up @@ -527,7 +527,7 @@ test-ci-js: | clear-stalled
.PHONY: test-ci
# Related CI jobs: most CI tests, excluding node-test-commit-arm-fanned
test-ci: LOGLEVEL := info
test-ci: | clear-stalled build-addons build-js-native-api-tests build-node-api-tests doc-only
test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tests build-node-api-tests doc-only
out/Release/cctest --gtest_output=xml:out/junit/cctest.xml
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
Expand Down
4 changes: 4 additions & 0 deletions test/benchmark/benchmark.status
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@ prefix benchmark
[$system==aix]

[$arch==arm]
# https://github.com/nodejs/node/issues/34266
test-benchmark-fs: SKIP
# https://github.com/nodejs/build/issues/2382
test-benchmark-napi: SKIP
2 changes: 1 addition & 1 deletion vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cd %~dp0

@rem CI_* variables should be kept synchronized with the ones in Makefile
set CI_NATIVE_SUITES=addons js-native-api node-api
set CI_JS_SUITES=default
set CI_JS_SUITES=default benchmark
set CI_DOC=doctool
@rem Same as the test-ci target in Makefile
set "common_test_suites=%CI_JS_SUITES% %CI_NATIVE_SUITES% %CI_DOC%&set build_addons=1&set build_js_native_api_tests=1&set build_node_api_tests=1"
Expand Down

0 comments on commit b24f254

Please sign in to comment.