From b1c7889ad7b5c541ef227b80258f6081d176bc58 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 21 Oct 2017 11:10:42 -0700 Subject: [PATCH] test: fix common.PIPE path bug `common.PIPE` is returning a path name in `test` rather than in the `tmp` directory for each test. This is causing multiple test failures in CI. Make the path name inside the temporary directories again. This way the pipe is removed by `common.refreshTmpDir()` on POSIX. The bug in `common.PIPE` was introduced in c34ae48083b44f1da7be75c8d11abc9f3aa7ab19. PR-URL: https://github.com/nodejs/node/pull/16364 Fixes: https://github.com/nodejs/node/issues/16290 Fixes: https://github.com/nodejs/node/issues/16323 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Anatoli Papirovski --- test/common/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common/index.js b/test/common/index.js index a138b4d3da0063..9a9352bbb2f4ff 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -274,7 +274,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', { const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`); const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative; const pipeName = `node-test.${process.pid}.sock`; - exports.PIPE = pipePrefix + pipeName; + exports.PIPE = path.join(pipePrefix, pipeName); } {