From b1bbedd701631d5fd3305737c15b16110fc619a9 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 19 Nov 2018 00:01:51 -0800 Subject: [PATCH] doc: edit COLLABORATOR_GUIDE.md on closing issues Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: https://github.com/nodejs/node/pull/24477 Reviewed-By: Weijia Wang Reviewed-By: Anna Henningsen Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Franziska Hinkelmann Reviewed-By: Luigi Pinca --- COLLABORATOR_GUIDE.md | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 1eb75fc1f8d703..4d0be355d5881d 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -61,13 +61,11 @@ as a _Contributor_. Ask if they have configured their git ### Closing Issues and Pull Requests -Collaborators may close any issue or pull request they believe is -not relevant for the future of the Node.js project. Where this is -unclear, the issue should be left open for several days to allow for -additional discussion. Where this does not yield input from Node.js -Collaborators or additional evidence that the issue has relevance, the -issue may be closed. Remember that issues can always be re-opened if -necessary. +Collaborators may close any issue or pull request that is not relevant to the +future of the Node.js project. Where this is unclear, leave the issue or pull +request open for several days to allow for discussion. Where this does not yield +evidence that the issue or pull request has relevance, close it. Remember that +issues and pull requests can always be re-opened if necessary. ### Author ready pull requests