test: fix unreliable test-fs-stat-bigint

Remove side-effects between testcases by creating a new file everytime. Fixes: #21948 PR-URL: #21949 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jul 26, 2018 · af6b824 · af6b824
1 parent 793a5bb
commit af6b824
Showing 1 changed file with 29 additions and 15 deletions.
diff --git a/test/parallel/test-fs-stat-bigint.js b/test/parallel/test-fs-stat-bigint.js
@@ -10,13 +10,12 @@ const { isDate } = require('util').types;
 
 tmpdir.refresh();
 
-const fn = path.join(tmpdir.path, 'test-file');
-fs.writeFileSync(fn, 'test');
+let testIndex = 0;
 
-let link;
-if (!common.isWindows) {
-  link = path.join(tmpdir.path, 'symbolic-link');
-  fs.symlinkSync(fn, link);
+function getFilename() {
+  const filename = path.join(tmpdir.path, `test-file-${++testIndex}`);
+  fs.writeFileSync(filename, 'test');
+  return filename;
 }
 
 function verifyStats(bigintStats, numStats) {
@@ -74,34 +73,43 @@ function verifyStats(bigintStats, numStats) {
 }
 
 {
-  const bigintStats = fs.statSync(fn, { bigint: true });
-  const numStats = fs.statSync(fn);
+  const filename = getFilename();
+  const bigintStats = fs.statSync(filename, { bigint: true });
+  const numStats = fs.statSync(filename);
   verifyStats(bigintStats, numStats);
 }
 
 if (!common.isWindows) {
+  const filename = getFilename();
+  const link = `${filename}-link`;
+  fs.symlinkSync(filename, link);
   const bigintStats = fs.lstatSync(link, { bigint: true });
   const numStats = fs.lstatSync(link);
   verifyStats(bigintStats, numStats);
 }
 
 {
-  const fd = fs.openSync(fn, 'r');
+  const filename = getFilename();
+  const fd = fs.openSync(filename, 'r');
   const bigintStats = fs.fstatSync(fd, { bigint: true });
   const numStats = fs.fstatSync(fd);
   verifyStats(bigintStats, numStats);
   fs.closeSync(fd);
 }
 
 {
-  fs.stat(fn, { bigint: true }, (err, bigintStats) => {
-    fs.stat(fn, (err, numStats) => {
+  const filename = getFilename();
+  fs.stat(filename, { bigint: true }, (err, bigintStats) => {
+    fs.stat(filename, (err, numStats) => {
       verifyStats(bigintStats, numStats);
     });
   });
 }
 
 if (!common.isWindows) {
+  const filename = getFilename();
+  const link = `${filename}-link`;
+  fs.symlinkSync(filename, link);
   fs.lstat(link, { bigint: true }, (err, bigintStats) => {
     fs.lstat(link, (err, numStats) => {
       verifyStats(bigintStats, numStats);
@@ -110,7 +118,8 @@ if (!common.isWindows) {
 }
 
 {
-  const fd = fs.openSync(fn, 'r');
+  const filename = getFilename();
+  const fd = fs.openSync(filename, 'r');
   fs.fstat(fd, { bigint: true }, (err, bigintStats) => {
     fs.fstat(fd, (err, numStats) => {
       verifyStats(bigintStats, numStats);
@@ -120,21 +129,26 @@ if (!common.isWindows) {
 }
 
 (async function() {
-  const bigintStats = await promiseFs.stat(fn, { bigint: true });
-  const numStats = await promiseFs.stat(fn);
+  const filename = getFilename();
+  const bigintStats = await promiseFs.stat(filename, { bigint: true });
+  const numStats = await promiseFs.stat(filename);
   verifyStats(bigintStats, numStats);
 })();
 
 if (!common.isWindows) {
   (async function() {
+    const filename = getFilename();
+    const link = `${filename}-link`;
+    fs.symlinkSync(filename, link);
     const bigintStats = await promiseFs.lstat(link, { bigint: true });
     const numStats = await promiseFs.lstat(link);
     verifyStats(bigintStats, numStats);
   })();
 }
 
 (async function() {
-  const handle = await promiseFs.open(fn, 'r');
+  const filename = getFilename();
+  const handle = await promiseFs.open(filename, 'r');
   const bigintStats = await handle.stat({ bigint: true });
   const numStats = await handle.stat();
   verifyStats(bigintStats, numStats);