module: refactor NativeModule to avoid unsafe array iteration

PR-URL: #37656 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
nodejs · Mar 16, 2021 · ae0e76c · ae0e76c
1 parent a2d08d5
commit ae0e76c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -46,6 +46,7 @@
 const {
   ArrayPrototypeMap,
   ArrayPrototypePush,
+  ArrayPrototypeSlice,
   Error,
   ObjectCreate,
   ObjectDefineProperty,
@@ -239,8 +240,10 @@ class NativeModule {
     const { ModuleWrap } = internalBinding('module_wrap');
     const url = `node:${this.id}`;
     const nativeModule = this;
+    const exportsKeys = ArrayPrototypeSlice(this.exportKeys);
+    ArrayPrototypePush(exportsKeys, 'default');
     this.module = new ModuleWrap(
-      url, undefined, [...this.exportKeys, 'default'],
+      url, undefined, exportsKeys,
       function() {
         nativeModule.syncExports();
         this.setExport('default', nativeModule.exports);