Skip to content

Commit

Permalink
doc: note that linting is required in releases.md
Browse files Browse the repository at this point in the history
Refs: #18769

PR-URL: #18776
Refs: #18769
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
gibfahn authored and MylesBorins committed Aug 16, 2018
1 parent d55e4ad commit adca631
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions doc/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,9 @@ Merge your release proposal branch into the stable branch that you are releasing

Cherry-pick the release commit to `master`. After cherry-picking, edit `src/node_version.h` to ensure the version macros contain whatever values were previously on `master`. `NODE_VERSION_IS_RELEASE` should be `0`.

Run `make lint-md-build; make lint` before pushing to `master`, to make sure the
Changelog formatting passes the lint rules on `master`.

### 12. Promote and Sign the Release Builds

**It is important that the same individual who signed the release tag be the one to promote the builds as the SHASUMS256.txt file needs to be signed with the same GPG key!**
Expand Down

0 comments on commit adca631

Please sign in to comment.