Revert "repl: handle buffered string logic on finish"

This reverts commit eb42c1e. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
nodejs · Dec 7, 2018 · adae559 · adae559
1 parent 5ab22c8
commit adae559
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -356,9 +356,9 @@ Interface.prototype.undoHistory = function() {
 
 // If it's a multiline code, then add history
 // accordingly.
-Interface.prototype.multilineHistory = function(clearBuffer) {
-  // if not clear buffer, add multiline history
-  if (!clearBuffer && this.terminal) {
+Interface.prototype.multilineHistory = function() {
+  // check if we got a multiline code
+  if (this.multiline !== '' && this.terminal) {
     const dupIndex = this.history.indexOf(this.multiline);
     if (dupIndex !== -1) this.history.splice(dupIndex, 1);
     // Remove the last entered line as multiline

diff --git a/lib/repl.js b/lib/repl.js
@@ -667,13 +667,6 @@ function REPLServer(prompt,
         }
       }
 
-      // handle multiline history
-      if (self[kBufferedCommandSymbol].length)
-        REPLServer.super_.prototype.multilineHistory.call(self, false);
-      else {
-        REPLServer.super_.prototype.multilineHistory.call(self, true);
-      }
-
       // Clear buffer if no SyntaxErrors
       self.clearBufferedCommand();
       sawCtrlD = false;
@@ -780,6 +773,7 @@ exports.start = function(prompt,
 
 REPLServer.prototype.clearBufferedCommand = function clearBufferedCommand() {
   this[kBufferedCommandSymbol] = '';
+  REPLServer.super_.prototype.multilineHistory.call(this);
 };
 
 REPLServer.prototype.close = function close() {