Skip to content

Commit

Permalink
test: properly tag anonymous namespaces
Browse files Browse the repository at this point in the history
For tests that use anonymous namespaces, some tagged the close
of the namespace with 'namespace' while others used
'anonymous namespace'. It was suggested I should use
'anonymous namespace' in a recent PR review so make all of the
tests consistent with this.

PR-URL: #18583
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
mhdawson authored and rvagg committed Aug 16, 2018
1 parent c5eb1f8 commit ad862a0
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion test/addons-napi/test_make_callback_recurse/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ napi_value Init(napi_env env, napi_value exports) {
return exports;
}

} // namespace
} // anonymous namespace

NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons/async-hooks-id/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "emitAsyncInit", EmitAsyncInit);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/async-resource/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,6 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "getResource", GetResource);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/callback-scope/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,6 @@ void Initialize(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "testResolveAsync", TestResolveAsync);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/make-callback-recurse/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/make-callback/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ void Initialize(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
}

} // namespace
} // anonymous namespace

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/cctest/test_inspector_socket_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ static const std::string WsHandshakeRequest(const std::string& target_id) {
"Sec-WebSocket-Key: aaa==\r\n"
"Sec-WebSocket-Version: 13\r\n\r\n";
}
} // namespace
} // anonymous namespace


TEST_F(InspectorSocketServerTest, InspectorSessions) {
Expand Down

0 comments on commit ad862a0

Please sign in to comment.