Skip to content

Commit

Permalink
test: remove harmony flags
Browse files Browse the repository at this point in the history
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: #22285
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
BridgeAR authored and targos committed Sep 3, 2018
1 parent e9ac683 commit acfb724
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 27 deletions.
10 changes: 2 additions & 8 deletions doc/api/util.md
Original file line number Diff line number Diff line change
Expand Up @@ -1026,10 +1026,7 @@ added: v10.0.0
* `value` {any}
* Returns: {boolean}

Returns `true` if the value is a `BigInt64Array` instance. The
`--harmony-bigint` command line flag is required in order to use the
`BigInt64Array` type, but it is not required in order to use
`isBigInt64Array()`.
Returns `true` if the value is a `BigInt64Array` instance.

For example:

Expand All @@ -1046,10 +1043,7 @@ added: v10.0.0
* `value` {any}
* Returns: {boolean}

Returns `true` if the value is a `BigUint64Array` instance. The
`--harmony-bigint` command line flag is required in order to use the
`BigUint64Array` type, but it is not required in order to use
`isBigUint64Array()`.
Returns `true` if the value is a `BigUint64Array` instance.

For example:

Expand Down
4 changes: 0 additions & 4 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2974,10 +2974,6 @@ static void ParseArgs(int* argc,
config_preserve_symlinks_main = true;
} else if (strcmp(arg, "--experimental-modules") == 0) {
config_experimental_modules = true;
new_v8_argv[new_v8_argc] = "--harmony-dynamic-import";
new_v8_argc += 1;
new_v8_argv[new_v8_argc] = "--harmony-import-meta";
new_v8_argc += 1;
} else if (strcmp(arg, "--experimental-vm-modules") == 0) {
config_experimental_vm_modules = true;
} else if (strcmp(arg, "--experimental-worker") == 0) {
Expand Down
12 changes: 0 additions & 12 deletions test/parallel/test-util-inspect-bigint.js

This file was deleted.

5 changes: 5 additions & 0 deletions test/parallel/test-util-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const JSStream = process.binding('js_stream').JSStream;
const util = require('util');
const vm = require('vm');
const { previewEntries } = process.binding('util');
const { inspect } = util;

assert.strictEqual(util.inspect(1), '1');
assert.strictEqual(util.inspect(false), 'false');
Expand Down Expand Up @@ -1672,3 +1673,7 @@ util.inspect(process);
value.foo = 'bar';
assert.notStrictEqual(util.inspect(value), expected);
});

assert.strictEqual(inspect(1n), '1n');
assert.strictEqual(inspect(Object(-1n)), '[BigInt: -1n]');
assert.strictEqual(inspect(Object(13n)), '[BigInt: 13n]');
2 changes: 1 addition & 1 deletion test/parallel/test-util-types.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Flags: --harmony-bigint --experimental-vm-modules
// Flags: --experimental-vm-modules
'use strict';
require('../common');
const fixtures = require('../common/fixtures');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-vm-module-dynamic-import.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

// Flags: --experimental-vm-modules --experimental-modules --harmony-dynamic-import
// Flags: --experimental-vm-modules --experimental-modules

const common = require('../common');

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-vm-module-import-meta.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

// Flags: --experimental-vm-modules --harmony-import-meta
// Flags: --experimental-vm-modules

const common = require('../common');
const assert = require('assert');
Expand Down

0 comments on commit acfb724

Please sign in to comment.