test: remove harmony flags

v8 6.8 supports all removed flags. For example for BigInt. PR-URL: #22285 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Sep 3, 2018 · acfb724 · acfb724
1 parent e9ac683
commit acfb724
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 27 deletions.
diff --git a/doc/api/util.md b/doc/api/util.md
@@ -1026,10 +1026,7 @@ added: v10.0.0
 * `value` {any}
 * Returns: {boolean}
 
-Returns `true` if the value is a `BigInt64Array` instance. The
-`--harmony-bigint` command line flag is required in order to use the
-`BigInt64Array` type, but it is not required in order to use
-`isBigInt64Array()`.
+Returns `true` if the value is a `BigInt64Array` instance.
 
 For example:
 
@@ -1046,10 +1043,7 @@ added: v10.0.0
 * `value` {any}
 * Returns: {boolean}
 
-Returns `true` if the value is a `BigUint64Array` instance. The
-`--harmony-bigint` command line flag is required in order to use the
-`BigUint64Array` type, but it is not required in order to use
-`isBigUint64Array()`.
+Returns `true` if the value is a `BigUint64Array` instance.
 
 For example:
 

diff --git a/src/node.cc b/src/node.cc
@@ -2974,10 +2974,6 @@ static void ParseArgs(int* argc,
       config_preserve_symlinks_main = true;
     } else if (strcmp(arg, "--experimental-modules") == 0) {
       config_experimental_modules = true;
-      new_v8_argv[new_v8_argc] = "--harmony-dynamic-import";
-      new_v8_argc += 1;
-      new_v8_argv[new_v8_argc] = "--harmony-import-meta";
-      new_v8_argc += 1;
     } else if (strcmp(arg, "--experimental-vm-modules") == 0) {
       config_experimental_vm_modules = true;
     } else if (strcmp(arg, "--experimental-worker") == 0) {

diff --git a/test/parallel/test-util-inspect-bigint.js b/test/parallel/test-util-inspect-bigint.js
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -26,6 +26,7 @@ const JSStream = process.binding('js_stream').JSStream;
 const util = require('util');
 const vm = require('vm');
 const { previewEntries } = process.binding('util');
+const { inspect } = util;
 
 assert.strictEqual(util.inspect(1), '1');
 assert.strictEqual(util.inspect(false), 'false');
@@ -1672,3 +1673,7 @@ util.inspect(process);
   value.foo = 'bar';
   assert.notStrictEqual(util.inspect(value), expected);
 });
+
+assert.strictEqual(inspect(1n), '1n');
+assert.strictEqual(inspect(Object(-1n)), '[BigInt: -1n]');
+assert.strictEqual(inspect(Object(13n)), '[BigInt: 13n]');
diff --git a/test/parallel/test-util-types.js b/test/parallel/test-util-types.js
@@ -1,4 +1,4 @@
-// Flags: --harmony-bigint --experimental-vm-modules
+// Flags: --experimental-vm-modules
 'use strict';
 require('../common');
 const fixtures = require('../common/fixtures');

diff --git a/test/parallel/test-vm-module-dynamic-import.js b/test/parallel/test-vm-module-dynamic-import.js
@@ -1,6 +1,6 @@
 'use strict';
 
-// Flags: --experimental-vm-modules --experimental-modules --harmony-dynamic-import
+// Flags: --experimental-vm-modules --experimental-modules
 
 const common = require('../common');
 

diff --git a/test/parallel/test-vm-module-import-meta.js b/test/parallel/test-vm-module-import-meta.js
@@ -1,6 +1,6 @@
 'use strict';
 
-// Flags: --experimental-vm-modules --harmony-import-meta
+// Flags: --experimental-vm-modules
 
 const common = require('../common');
 const assert = require('assert');