From a9cb6723b5f3e626d0bcec3645831a9c2b3e21ba Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Sun, 24 Jul 2022 05:01:14 -0700 Subject: [PATCH] doc: remind backporter about v8_embedder_string MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There's already a reminder earlier in the instructions, but not in the worked example, so it's easy to miss while skimming. PR-URL: https://github.com/nodejs/node/pull/43924 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Beth Griggs Reviewed-By: Joyee Cheung Reviewed-By: Darshan Sen --- doc/contributing/maintaining-V8.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/contributing/maintaining-V8.md b/doc/contributing/maintaining-V8.md index fde030b2e95712..d11a436d1247c1 100644 --- a/doc/contributing/maintaining-V8.md +++ b/doc/contributing/maintaining-V8.md @@ -270,6 +270,7 @@ Refs: https://github.com/v8/v8/commit/a51f429772d1e796744244128c9feeab4c26a854 PR-URL: https://github.com/nodejs/node/pull/7833 ``` +* Increase the `v8_embedder_string` number in `common.gypi`. * Open a PR against the `v6.x-staging` branch in the Node.js repository. Launch the normal and [V8 CI][] using the Node.js CI system. We only needed to backport to `v6.x` as the other LTS branches weren't affected by this bug.