crypto: fix input validation in crypto.hash

PR-URL: #52070 Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · May 3, 2024 · a6eede3 · a6eede3
1 parent e5521b5
commit a6eede3
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/internal/crypto/hash.js b/lib/internal/crypto/hash.js
@@ -52,7 +52,6 @@ const {
   validateEncoding,
   validateString,
   validateUint32,
-  validateBuffer,
 } = require('internal/validators');
 
 const {
@@ -196,8 +195,8 @@ async function asyncDigest(algorithm, data) {
 
 function hash(algorithm, input, outputEncoding = 'hex') {
   validateString(algorithm, 'algorithm');
-  if (typeof input !== 'string') {
-    validateBuffer(input, 'input');
+  if (typeof input !== 'string' && !isArrayBufferView(input)) {
+    throw new ERR_INVALID_ARG_TYPE('input', ['Buffer', 'TypedArray', 'DataView', 'string'], input);
   }
   let normalized = outputEncoding;
   // Fast case: if it's 'hex', we don't need to validate it further.