stream: validate abort signal

PR-URL: #39346 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Jul 12, 2021 · a5dec3a · a5dec3a
1 parent de85b1e
commit a5dec3a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -43,7 +43,7 @@ const { Stream, prependListener } = require('internal/streams/legacy');
 const { Buffer } = require('buffer');
 
 const {
-  addAbortSignalNoValidate,
+  addAbortSignal,
 } = require('internal/streams/add-abort-signal');
 const eos = require('internal/streams/end-of-stream');
 
@@ -199,8 +199,9 @@ function Readable(options) {
 
     if (typeof options.construct === 'function')
       this._construct = options.construct;
+
     if (options.signal && !isDuplex)
-      addAbortSignalNoValidate(options.signal, this);
+      addAbortSignal(options.signal, this);
   }
 
   Stream.call(this, options);

diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -46,7 +46,7 @@ const { Buffer } = require('buffer');
 const destroyImpl = require('internal/streams/destroy');
 
 const {
-  addAbortSignalNoValidate,
+  addAbortSignal,
 } = require('internal/streams/add-abort-signal');
 
 const {
@@ -249,8 +249,9 @@ function Writable(options) {
 
     if (typeof options.construct === 'function')
       this._construct = options.construct;
+
     if (options.signal)
-      addAbortSignalNoValidate(options.signal, this);
+      addAbortSignal(options.signal, this);
   }
 
   Stream.call(this, options);