-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: ensure _handle property existence
`test-stdtout-close-unref.js` will fail if `process.stdin._handle` does not exist. On UNIX-like operating systems, you can see this failure this way: ./node test/parallel/test-stdout-close-unref.js < /dev/null This issue has been experienced by @bengl and @drewfish in a Docker container. I'm not sure why they are experiencing it in their environment, but since it is possible that the `_handle` property does not exist, let's use `child_process.spawn()` to make sure it exists. PR-URL: #5916 Reviewed-By: Jeremiah Senkpiel <[email protected]>
- Loading branch information
Showing
1 changed file
with
26 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,30 @@ | ||
'use strict'; | ||
require('../common'); | ||
var assert = require('assert'); | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const spawn = require('child_process').spawn; | ||
|
||
var errs = 0; | ||
if (process.argv[2] === 'child') { | ||
var errs = 0; | ||
|
||
process.stdin.resume(); | ||
process.stdin._handle.close(); | ||
process.stdin._handle.unref(); // Should not segfault. | ||
process.stdin.on('error', function(err) { | ||
errs++; | ||
}); | ||
process.stdin.resume(); | ||
process.stdin._handle.close(); | ||
process.stdin._handle.unref(); // Should not segfault. | ||
process.stdin.on('error', function(err) { | ||
errs++; | ||
}); | ||
|
||
process.on('exit', function() { | ||
assert.strictEqual(errs, 1); | ||
}); | ||
process.on('exit', function() { | ||
assert.strictEqual(errs, 1); | ||
}); | ||
return; | ||
} | ||
|
||
// Use spawn so that we can be sure that stdin has a _handle property. | ||
// Refs: https://github.com/nodejs/node/pull/5916 | ||
const proc = spawn(process.execPath, [__filename, 'child'], { stdio: 'pipe' }); | ||
|
||
proc.stderr.pipe(process.stderr); | ||
proc.on('exit', common.mustCall(function(exitCode) { | ||
if (exitCode !== 0) | ||
process.exitCode = exitCode; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
Trott
Author
Member
|
||
})); |
@Trott btw, if the process errors after this, the exit code will be overriden anyways.
If node core set it before, it won't reach here because that means it must be exiting somewhere, afaik.