From a103712a625b9a9fd124250e864d497e9e9e95a4 Mon Sep 17 00:00:00 2001 From: Julien Gilli Date: Mon, 16 Feb 2015 15:45:08 -0800 Subject: [PATCH] deps: do not add extra newline in log file The commit in v0.10 (431eb172f97434a3b0868a610bc14d8ff7d9efd9) that backported the original change (https://codereview.chromium.org/806143002) did add an extra newline because the logging facilities in v0.10's V8 do not add one. When merging this commit in v0.12, V8's logging facilities now automatically add the newline character, and the debug builds assert if one is already present. --- deps/v8/src/log-utils.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/v8/src/log-utils.cc b/deps/v8/src/log-utils.cc index 748d23a0d6ac8e..d3dbe143c61f38 100644 --- a/deps/v8/src/log-utils.cc +++ b/deps/v8/src/log-utils.cc @@ -54,7 +54,7 @@ void Log::Initialize(const char* log_file_name) { if (output_handle_ != NULL) { Log::MessageBuilder msg(this); - msg.Append("v8-version,%d,%d,%d,%d,%d\n", Version::GetMajor(), + msg.Append("v8-version,%d,%d,%d,%d,%d", Version::GetMajor(), Version::GetMinor(), Version::GetBuild(), Version::GetPatch(), Version::IsCandidate()); msg.WriteToLogFile();