tty: initialize winSize array with values

Assigning to a holey array in the native layer may crash if it has getters that throw. Refs: #54186 PR-URL: #54281 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs · Oct 2, 2024 · a033dff · a033dff
1 parent 93ee36e
commit a033dff
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/tty.js b/lib/tty.js
@@ -22,7 +22,6 @@
 'use strict';
 
 const {
-  Array,
   NumberIsInteger,
   ObjectSetPrototypeOf,
 } = primordials;
@@ -106,7 +105,7 @@ function WriteStream(fd) {
   // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
   this._handle.setBlocking(true);
 
-  const winSize = new Array(2);
+  const winSize = [0, 0];
   const err = this._handle.getWindowSize(winSize);
   if (!err) {
     this.columns = winSize[0];
@@ -126,7 +125,7 @@ WriteStream.prototype.hasColors = hasColors;
 WriteStream.prototype._refreshSize = function() {
   const oldCols = this.columns;
   const oldRows = this.rows;
-  const winSize = new Array(2);
+  const winSize = [0, 0];
   const err = this._handle.getWindowSize(winSize);
   if (err) {
     this.emit('error', new errors.ErrnoException(err, 'getWindowSize'));