console: avoid adding infinite error listeners

If the console destination is a unix pipe (net.Socket), write() is
async. If the destination is broken, we are adding an 'error' event
listener to avoid a process crash. This PR makes sure that we are adding
that listener only once.

Fixes: #16767

PR-URL: #16770
Fixes: #16767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>

lib/console.js

@@ -82,7 +82,10 @@ function createWriteErrorHandler(stream) {
       // an `error` event. Adding a `once` listener will keep that error
       // from becoming an uncaught exception, but since the handler is
       // removed after the event, non-console.* writes won’t be affected.
-      stream.once('error', noop);
+      // we are only adding noop if there is no one else listening for 'error'
+      if (stream.listenerCount('error') === 0) {
+        stream.on('error', noop);
+      }
     }
   };
 }

test/parallel/test-console-log-stdio-broken-dest.js

@@ -0,0 +1,24 @@
+'use strict';
+
+const common = require('../common');
+const { Writable } = require('stream');
+const { Console } = require('console');
+const { EventEmitter } = require('events');
+
+const stream = new Writable({
+  write(chunk, enc, cb) {
+    cb();
+  },
+  writev(chunks, cb) {
+    setTimeout(cb, 10, new Error('kaboom'));
+  }
+});
+const myConsole = new Console(stream, stream);
+
+process.on('warning', common.mustNotCall);
+
+stream.cork();
+for (let i = 0; i < EventEmitter.defaultMaxListeners + 1; i++) {
+  myConsole.log('a message');
+}
+stream.uncork();