diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js index 0522ecb2a276f2..0b725d5ba748fa 100644 --- a/lib/_http_outgoing.js +++ b/lib/_http_outgoing.js @@ -133,12 +133,6 @@ OutgoingMessage.prototype._writeRaw = function(data, encoding, callback) { encoding = null; } - if (data.length === 0) { - if (typeof callback === 'function') - process.nextTick(callback); - return true; - } - var connection = this.connection; if (connection && connection._httpMessage === this && @@ -158,6 +152,10 @@ OutgoingMessage.prototype._writeRaw = function(data, encoding, callback) { this.output = []; this.outputEncodings = []; this.outputCallbacks = []; + } else if (data.length === 0) { + if (typeof callback === 'function') + process.nextTick(callback); + return true; } // Directly write to socket. diff --git a/src/stream_base.cc b/src/stream_base.cc index 3139274c6fce34..27ae0fee7b1309 100644 --- a/src/stream_base.cc +++ b/src/stream_base.cc @@ -154,7 +154,7 @@ int StreamBase::Writev(const FunctionCallbackInfo& args) { // Write string offset = ROUND_UP(offset, WriteWrap::kAlignSize); - CHECK_LT(offset, storage_size); + CHECK_LE(offset, storage_size); char* str_storage = req_wrap->Extra(offset); size_t str_size = storage_size - offset; diff --git a/test/parallel/test-http-pipeline-regr-2639.js b/test/parallel/test-http-pipeline-regr-2639.js new file mode 100644 index 00000000000000..f1f75bff650ac5 --- /dev/null +++ b/test/parallel/test-http-pipeline-regr-2639.js @@ -0,0 +1,34 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const http = require('http'); +const net = require('net'); + +const COUNT = 10; + +var received = 0; + +var server = http.createServer(function(req, res) { + // Close the server, we have only one TCP connection anyway + if (received++ === 0) + server.close(); + + res.writeHead(200); + res.write('data'); + + setTimeout(function() { + res.end(); + }, (Math.random() * 100) | 0); +}).listen(common.PORT, function() { + const s = net.connect(common.PORT); + + var big = ''; + for (var i = 0; i < COUNT; i++) + big += 'GET / HTTP/1.0\r\n\r\n'; + s.write(big); + s.resume(); +}); + +process.on('exit', function() { + assert.equal(received, COUNT); +});