From 97e0efeedf4e3d113adf65ec8d1f91eacca18203 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sat, 7 Dec 2019 13:57:46 +0100 Subject: [PATCH] test: scale keepalive timeouts for slow machines The test was using fixed timeouts and that seems to be causing sporadic test failures on pi1-docker host (which is a very slow machine.) Fixes: https://github.com/nodejs/node/issues/30828 PR-URL: https://github.com/nodejs/node/pull/30834 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Gabriel Schulhof Reviewed-By: Rich Trott Reviewed-By: Ruben Bridgewater --- test/sequential/test-https-server-keep-alive-timeout.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/sequential/test-https-server-keep-alive-timeout.js b/test/sequential/test-https-server-keep-alive-timeout.js index 3c18d325c15b93..5ded520dc7aaf8 100644 --- a/test/sequential/test-https-server-keep-alive-timeout.js +++ b/test/sequential/test-https-server-keep-alive-timeout.js @@ -34,13 +34,13 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) { common.mustCall((req, res) => { res.end(); }, 3)); - server.setTimeout(500, common.mustCall((socket) => { + server.setTimeout(common.platformTimeout(500), common.mustCall((socket) => { // End this test and call `run()` for the next test (if any). socket.destroy(); server.close(); cb(); })); - server.keepAliveTimeout = 50; + server.keepAliveTimeout = common.platformTimeout(50); server.listen(0, common.mustCall(() => { const options = { port: server.address().port, @@ -57,13 +57,13 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) { test(function serverNoEndKeepAliveTimeoutWithPipeline(cb) { const server = https.createServer(serverOptions, common.mustCall(3)); - server.setTimeout(500, common.mustCall((socket) => { + server.setTimeout(common.platformTimeout(500), common.mustCall((socket) => { // End this test and call `run()` for the next test (if any). socket.destroy(); server.close(); cb(); })); - server.keepAliveTimeout = 50; + server.keepAliveTimeout = common.platformTimeout(50); server.listen(0, common.mustCall(() => { const options = { port: server.address().port,