Skip to content

Commit

Permalink
build: build ICU with ICU_NO_USER_DATA_OVERRIDE
Browse files Browse the repository at this point in the history
CVE-ID: CVE-2023-23920
Backport-PR-URL: nodejs-private/node-private#377
PR-URL: nodejs-private/node-private#374
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
RafaelGSS authored and richardlau committed Feb 14, 2023
1 parent 9e62215 commit 97a0443
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,9 @@ def icu_download(path):
# always set icu_small, node.gyp depends on it being defined.
o['variables']['icu_small'] = b(False)

# prevent data override
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']

with_intl = options.with_intl
with_icu_source = options.with_icu_source
have_icu_path = bool(options.with_icu_path)
Expand Down

0 comments on commit 97a0443

Please sign in to comment.