net: don't normalize twice in Socket#connect()

Split up Socket#connect() so that we don't call normalizeArgs() twice when invoking net.connect() or net.createConnection(). PR-URL: #12342 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · May 2, 2017 · 94385c6 · 94385c6
1 parent 0e40e6d
commit 94385c6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -73,7 +73,7 @@ function connect() {
     socket.setTimeout(options.timeout);
   }
 
-  return Socket.prototype.connect.call(socket, options, cb);
+  return realConnect.call(socket, options, cb);
 }
 
 
@@ -899,7 +899,11 @@ Socket.prototype.connect = function() {
   const normalized = normalizeArgs(args);
   const options = normalized[0];
   const cb = normalized[1];
+  return realConnect.call(this, options, cb);
+};
+
 
+function realConnect(options, cb) {
   if (this.write !== Socket.prototype.write)
     this.write = Socket.prototype.write;
 
@@ -940,7 +944,7 @@ Socket.prototype.connect = function() {
     lookupAndConnect(this, options);
   }
   return this;
-};
+}
 
 
 function lookupAndConnect(self, options) {