lib: replace Symbol.asyncIterator by SymbolAsyncIterator

PR-URL: #30947 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 17, 2019 · 92475e9 · 92475e9
1 parent 19f05ca
commit 92475e9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -27,7 +27,7 @@ const {
   NumberIsNaN,
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
-  Symbol,
+  SymbolAsyncIterator,
 } = primordials;
 
 module.exports = Readable;
@@ -1096,7 +1096,7 @@ Readable.prototype.wrap = function(stream) {
   return this;
 };
 
-Readable.prototype[Symbol.asyncIterator] = function() {
+Readable.prototype[SymbolAsyncIterator] = function() {
   if (createReadableStreamAsyncIterator === undefined) {
     createReadableStreamAsyncIterator =
       require('internal/streams/async_iterator');

diff --git a/lib/internal/fs/dir.js b/lib/internal/fs/dir.js
@@ -3,6 +3,7 @@
 const {
   ObjectDefineProperty,
   Symbol,
+  SymbolAsyncIterator,
 } = primordials;
 
 const pathModule = require('path');
@@ -175,7 +176,7 @@ class Dir {
   }
 }
 
-ObjectDefineProperty(Dir.prototype, Symbol.asyncIterator, {
+ObjectDefineProperty(Dir.prototype, SymbolAsyncIterator, {
   value: Dir.prototype.entries,
   enumerable: false,
   writable: true,

diff --git a/lib/internal/streams/from.js b/lib/internal/streams/from.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const {
-  Symbol,
+  SymbolAsyncIterator,
   SymbolIterator
 } = primordials;
 const { Buffer } = require('buffer');
@@ -23,8 +23,8 @@ function from(Readable, iterable, opts) {
     });
   }
 
-  if (iterable && iterable[Symbol.asyncIterator])
-    iterator = iterable[Symbol.asyncIterator]();
+  if (iterable && iterable[SymbolAsyncIterator])
+    iterator = iterable[SymbolAsyncIterator]();
   else if (iterable && iterable[SymbolIterator])
     iterator = iterable[SymbolIterator]();
   else

diff --git a/lib/readline.js b/lib/readline.js
@@ -37,6 +37,7 @@ const {
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
   Symbol,
+  SymbolAsyncIterator,
 } = primordials;
 
 const {
@@ -1078,7 +1079,7 @@ Interface.prototype._ttyWrite = function(s, key) {
   }
 };
 
-Interface.prototype[Symbol.asyncIterator] = function() {
+Interface.prototype[SymbolAsyncIterator] = function() {
   if (this[kLineObjectStream] === undefined) {
     if (Readable === undefined) {
       Readable = require('stream').Readable;
@@ -1108,7 +1109,7 @@ Interface.prototype[Symbol.asyncIterator] = function() {
     this[kLineObjectStream] = readable;
   }
 
-  return this[kLineObjectStream][Symbol.asyncIterator]();
+  return this[kLineObjectStream][SymbolAsyncIterator]();
 };
 
 /**