From 8cc181c8eeb724d4ce0613fcc515857681bddbe9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 30 Mar 2019 15:21:30 +0100 Subject: [PATCH] deps: V8: cherry-pick c8785d1 Original commit message: [heap, api] Advance deprecations around global handles Bug: chromium:923361, v8:8834 Change-Id: I46b6ad9eaa86476963a4e2cb3a5712447f180c20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528235 Auto-Submit: Michael Lippautz Commit-Queue: Ulan Degenbaev Reviewed-by: Ulan Degenbaev Cr-Commit-Position: refs/heads/master@{#60303} Refs: https://github.com/v8/v8/commit/c8785d1572b8b7d7dc4df3578e249312a30be4b9 PR-URL: https://github.com/nodejs/node/pull/27013 Reviewed-By: Anna Henningsen Reviewed-By: Gus Caplan Reviewed-By: Ruben Bridgewater Reviewed-By: Ben Noordhuis --- common.gypi | 2 +- deps/v8/include/v8-util.h | 2 +- deps/v8/include/v8.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common.gypi b/common.gypi index bb089b6527d914..8d00e6864a52ba 100644 --- a/common.gypi +++ b/common.gypi @@ -37,7 +37,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.14', + 'v8_embedder_string': '-node.15', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-util.h b/deps/v8/include/v8-util.h index 466b99fd6b717e..24962607076f78 100644 --- a/deps/v8/include/v8-util.h +++ b/deps/v8/include/v8-util.h @@ -198,7 +198,7 @@ class PersistentValueMapBase { * Call V8::RegisterExternallyReferencedObject with the map value for given * key. */ - V8_DEPRECATE_SOON( + V8_DEPRECATED( "Used TracedGlobal and EmbedderHeapTracer::RegisterEmbedderReference", inline void RegisterExternallyReferencedObject(K& key)); diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 8bb2990c494ad5..7346e0bbbc74c2 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -549,7 +549,7 @@ template class PersistentBase { * is alive. Only allowed when the embedder is asked to trace its heap by * EmbedderHeapTracer. */ - V8_DEPRECATE_SOON( + V8_DEPRECATED( "Used TracedGlobal and EmbedderHeapTracer::RegisterEmbedderReference", V8_INLINE void RegisterExternalReference(Isolate* isolate) const); @@ -572,7 +572,7 @@ template class PersistentBase { * * This bit is cleared after the each garbage collection pass. */ - V8_DEPRECATE_SOON("Use TracedGlobal.", V8_INLINE void MarkActive()); + V8_DEPRECATED("Use TracedGlobal.", V8_INLINE void MarkActive()); V8_DEPRECATED("See MarkIndependent.", V8_INLINE bool IsIndependent() const);