diff --git a/Makefile b/Makefile index 7a8e5453047411..aaf9d9262ff976 100644 --- a/Makefile +++ b/Makefile @@ -186,14 +186,13 @@ test/addons/.buildstamp: config.gypi \ # TODO(bnoordhuis) Force rebuild after gyp update. build-addons: $(NODE_EXE) test/addons/.buildstamp -ifeq ($(OSTYPE),$(filter $(OSTYPE),darwin aix)) - XARGS = xargs -else - XARGS = xargs -r -endif clear-stalled: + # Clean up any leftover processes but don't error if found. ps awwx | grep Release/node | grep -v grep | cat - ps awwx | grep Release/node | grep -v grep | awk '{print $$1}' | $(XARGS) kill + @PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ + if [ "$${PS_OUT}" ]; then \ + echo $${PS_OUT} | xargs kill; \ + fi test-gc: all test/gc/node_modules/weak/build/Release/weakref.node $(PYTHON) tools/test.py --mode=release gc @@ -221,8 +220,9 @@ test-ci-js: | clear-stalled $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ --mode=release --flaky-tests=$(FLAKY_TESTS) \ $(TEST_CI_ARGS) $(CI_JS_SUITES) - # Clean up any leftover processes - PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ + # Clean up any leftover processes, error if found. + ps awwx | grep Release/node | grep -v grep | cat + @PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ if [ "$${PS_OUT}" ]; then \ echo $${PS_OUT} | $(XARGS) kill; exit 1; \ fi @@ -233,10 +233,11 @@ test-ci: | clear-stalled build-addons $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ --mode=release --flaky-tests=$(FLAKY_TESTS) \ $(TEST_CI_ARGS) $(CI_NATIVE_SUITES) $(CI_JS_SUITES) - # Clean up any leftover processes - PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ + # Clean up any leftover processes, error if found. + ps awwx | grep Release/node | grep -v grep | cat + @PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ if [ "$${PS_OUT}" ]; then \ - echo $${PS_OUT} | $(XARGS) kill; exit 1; \ + echo $${PS_OUT} | xargs kill; exit 1; \ fi test-release: test-build