test: whitelist the expected modules in test-bootstrap-modules.js

Be explicit on the modules that are expected to be loaded and add an appropriate assertion failure message to help debug when the list changes. Fixes: #23884 PR-URL: #26531 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
nodejs · Mar 27, 2019 · 892282d · 892282d
1 parent 9092e12
commit 892282d
Showing 1 changed file with 123 additions and 7 deletions.
diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -3,15 +3,131 @@
 
 // This list must be computed before we require any modules to
 // to eliminate the noise.
-const list = process.moduleLoadList.slice();
+const actualModules = new Set(process.moduleLoadList.slice());
 
 const common = require('../common');
 const assert = require('assert');
 
-const isMainThread = common.isMainThread;
-const kCoverageModuleCount = process.env.NODE_V8_COVERAGE ? 1 : 0;
-const kMaxModuleCount = (isMainThread ? 65 : 88) + kCoverageModuleCount;
+const expectedModules = new Set([
+  'Internal Binding async_wrap',
+  'Internal Binding buffer',
+  'Internal Binding config',
+  'Internal Binding constants',
+  'Internal Binding contextify',
+  'Internal Binding credentials',
+  'Internal Binding fs',
+  'Internal Binding inspector',
+  'Internal Binding messaging',
+  'Internal Binding module_wrap',
+  'Internal Binding native_module',
+  'Internal Binding options',
+  'Internal Binding process_methods',
+  'Internal Binding task_queue',
+  'Internal Binding timers',
+  'Internal Binding trace_events',
+  'Internal Binding types',
+  'Internal Binding url',
+  'Internal Binding util',
+  'NativeModule buffer',
+  'NativeModule events',
+  'NativeModule fs',
+  'NativeModule internal/assert',
+  'NativeModule internal/async_hooks',
+  'NativeModule internal/bootstrap/pre_execution',
+  'NativeModule internal/buffer',
+  'NativeModule internal/console/constructor',
+  'NativeModule internal/console/global',
+  'NativeModule internal/constants',
+  'NativeModule internal/domexception',
+  'NativeModule internal/encoding',
+  'NativeModule internal/errors',
+  'NativeModule internal/fixed_queue',
+  'NativeModule internal/fs/utils',
+  'NativeModule internal/idna',
+  'NativeModule internal/linkedlist',
+  'NativeModule internal/modules/cjs/helpers',
+  'NativeModule internal/modules/cjs/loader',
+  'NativeModule internal/options',
+  'NativeModule internal/priority_queue',
+  'NativeModule internal/process/execution',
+  'NativeModule internal/process/next_tick',
+  'NativeModule internal/process/per_thread',
+  'NativeModule internal/process/promises',
+  'NativeModule internal/process/warning',
+  'NativeModule internal/querystring',
+  'NativeModule internal/timers',
+  'NativeModule internal/url',
+  'NativeModule internal/util',
+  'NativeModule internal/util/debuglog',
+  'NativeModule internal/util/inspect',
+  'NativeModule internal/util/types',
+  'NativeModule internal/validators',
+  'NativeModule path',
+  'NativeModule timers',
+  'NativeModule url',
+  'NativeModule util',
+  'NativeModule vm',
+]);
 
-assert(list.length <= kMaxModuleCount,
-       `Total length: ${list.length}\n` + list.join('\n')
-);
+if (common.isMainThread) {
+  expectedModules.add('NativeModule internal/process/main_thread_only');
+  expectedModules.add('NativeModule internal/process/stdio');
+} else {
+  expectedModules.add('Internal Binding heap_utils');
+  expectedModules.add('Internal Binding serdes');
+  expectedModules.add('Internal Binding stream_wrap');
+  expectedModules.add('Internal Binding symbols');
+  expectedModules.add('Internal Binding uv');
+  expectedModules.add('Internal Binding v8');
+  expectedModules.add('Internal Binding worker');
+  expectedModules.add('NativeModule _stream_duplex');
+  expectedModules.add('NativeModule _stream_passthrough');
+  expectedModules.add('NativeModule _stream_readable');
+  expectedModules.add('NativeModule _stream_transform');
+  expectedModules.add('NativeModule _stream_writable');
+  expectedModules.add('NativeModule internal/error-serdes');
+  expectedModules.add('NativeModule internal/process/worker_thread_only');
+  expectedModules.add('NativeModule internal/stream_base_commons');
+  expectedModules.add('NativeModule internal/streams/buffer_list');
+  expectedModules.add('NativeModule internal/streams/destroy');
+  expectedModules.add('NativeModule internal/streams/end-of-stream');
+  expectedModules.add('NativeModule internal/streams/legacy');
+  expectedModules.add('NativeModule internal/streams/pipeline');
+  expectedModules.add('NativeModule internal/streams/state');
+  expectedModules.add('NativeModule internal/worker');
+  expectedModules.add('NativeModule internal/worker/io');
+  expectedModules.add('NativeModule module');
+  expectedModules.add('NativeModule stream');
+  expectedModules.add('NativeModule v8');
+  expectedModules.add('NativeModule worker_threads');
+}
+
+if (common.hasIntl) {
+  expectedModules.add('Internal Binding icu');
+} else {
+  expectedModules.add('NativeModule punycode');
+}
+
+if (process.features.inspector) {
+  expectedModules.add('NativeModule internal/inspector_async_hook');
+  expectedModules.add('NativeModule internal/util/inspector');
+}
+
+if (process.env.NODE_V8_COVERAGE) {
+  expectedModules.add('NativeModule internal/profiler');
+}
+
+const difference = (setA, setB) => {
+  return new Set([...setA].filter((x) => !setB.has(x)));
+};
+const missingModules = difference(expectedModules, actualModules);
+const extraModules = difference(actualModules, expectedModules);
+const printSet = (s) => { return `${[...s].sort().join(',\n  ')}\n`; };
+
+assert.deepStrictEqual(actualModules, expectedModules,
+                       (missingModules.size > 0 ?
+                         'These modules were not loaded:\n  ' +
+                         printSet(missingModules) : '') +
+                       (extraModules.size > 0 ?
+                         'These modules were unexpectedly loaded:\n  ' +
+                         printSet(extraModules) : ''));