buffer: refactor create buffer

Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

PR-URL: #4340
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

lib/buffer.js

@@ -19,13 +19,17 @@ binding.setupBufferJS(Buffer.prototype, bindingObj);
 const flags = bindingObj.flags;
 const kNoZeroFill = 0;
 
+function createBuffer(size) {
+  const ui8 = new Uint8Array(size);
+  Object.setPrototypeOf(ui8, Buffer.prototype);
+  return ui8;
+}
 
 function createPool() {
   poolSize = Buffer.poolSize;
   if (poolSize > 0)
     flags[kNoZeroFill] = 1;
-  allocPool = new Uint8Array(poolSize);
-  Object.setPrototypeOf(allocPool, Buffer.prototype);
+  allocPool = createBuffer(poolSize);
   poolOffset = 0;
 }
 createPool();
@@ -67,9 +71,7 @@ function SlowBuffer(length) {
     length = 0;
   if (length > 0)
     flags[kNoZeroFill] = 1;
-  const ui8 = new Uint8Array(+length);
-  Object.setPrototypeOf(ui8, Buffer.prototype);
-  return ui8;
+  return createBuffer(+length);
 }
 
 Object.setPrototypeOf(SlowBuffer.prototype, Uint8Array.prototype);
@@ -78,9 +80,7 @@ Object.setPrototypeOf(SlowBuffer, Uint8Array);
 
 function allocate(size) {
   if (size === 0) {
-    const ui8 = new Uint8Array(size);
-    Object.setPrototypeOf(ui8, Buffer.prototype);
-    return ui8;
+    return createBuffer(size);
   }
   if (size < (Buffer.poolSize >>> 1)) {
     if (size > (poolSize - poolOffset))
@@ -95,9 +95,7 @@ function allocate(size) {
     // being zero filled.
     if (size > 0)
       flags[kNoZeroFill] = 1;
-    const ui8 = new Uint8Array(size);
-    Object.setPrototypeOf(ui8, Buffer.prototype);
-    return ui8;
+    return createBuffer(size);
   }
 }