build: don't rebuild test/gc add-on unnecessarily

Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: #11311 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
nodejs · Feb 22, 2017 · 86a6478 · 86a6478
1 parent 18599fc
commit 86a6478
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -133,8 +133,10 @@ test-parallel: all
 test-valgrind: all
 	$(PYTHON) tools/test.py --mode=release --valgrind sequential parallel message
 
-test/gc/build/Release/binding.node: \
-	$(NODE_EXE) test/gc/binding.cc test/gc/binding.gyp
+# Implicitly depends on $(NODE_EXE).  We don't depend on it explicitly because
+# it always triggers a rebuild due to it being a .PHONY rule.  See the comment
+# near the build-addons rule for more background.
+test/gc/build/Release/binding.node: test/gc/binding.cc test/gc/binding.gyp
 	$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
 		--python="$(PYTHON)" \
 		--directory="$(shell pwd)/test/gc" \