lib: add URI handling functions to primordials

PR-URL: #37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Feb 28, 2021 · 856d20b · 856d20b
1 parent df538eb
commit 856d20b
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 0 deletions.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -38,6 +38,10 @@ rules:
     - name: Boolean
     - name: DataView
     - name: Date
+    - name: decodeURI
+    - name: decodeURIComponent
+    - name: encodeURI
+    - name: encodeURIComponent
     - name: Error
       ignore:
         - prepareStackTrace

diff --git a/lib/internal/freeze_intrinsics.js b/lib/internal/freeze_intrinsics.js
@@ -107,6 +107,10 @@ const {
   WeakMapPrototype,
   WeakSet,
   WeakSetPrototype,
+  decodeURI,
+  decodeURIComponent,
+  encodeURI,
+  encodeURIComponent,
 } = primordials;
 
 module.exports = function() {

diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
@@ -137,6 +137,16 @@ function copyPrototype(src, dest, prefix) {
   }
 }
 
+// Create copies of URI handling functions
+[
+  decodeURI,
+  decodeURIComponent,
+  encodeURI,
+  encodeURIComponent,
+].forEach((fn) => {
+  primordials[fn.name] = fn;
+});
+
 // Create copies of the namespace objects
 [
   'JSON',

diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -30,6 +30,7 @@ const {
   Symbol,
   SymbolIterator,
   SymbolToStringTag,
+  decodeURIComponent,
 } = primordials;
 
 const { inspect } = require('internal/util/inspect');

diff --git a/lib/querystring.js b/lib/querystring.js
@@ -34,6 +34,7 @@ const {
   String,
   StringPrototypeCharCodeAt,
   StringPrototypeSlice,
+  decodeURIComponent,
 } = primordials;
 
 const { Buffer } = require('buffer');

diff --git a/lib/url.js b/lib/url.js
@@ -27,6 +27,7 @@ const {
   ObjectKeys,
   SafeSet,
   StringPrototypeCharCodeAt,
+  decodeURIComponent,
 } = primordials;
 
 const { toASCII } = require('internal/idna');