Skip to content

Commit

Permalink
build: fix --with-intl=system-icu for x-compile
Browse files Browse the repository at this point in the history
* add toolset stuff to icu-system.gyp
* update docs

Fixes: #3801
PR-URL: #3808
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
srl295 authored and jasnell committed Nov 15, 2015
1 parent 11ad744 commit 84f0964
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ Windows:
$ pkg-config --modversion icu-i18n && ./configure --with-intl=system-icu
```

If you are cross compiling, your `pkg-config` must be able to supply a path
that works for both your host and target environments.

#### Build with a specific ICU:

You can find other ICU releases at
Expand Down
2 changes: 2 additions & 0 deletions tools/icu/icu-system.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@
{
'target_name': 'icuuc',
'type': 'none',
'toolsets': [ 'host', 'target' ],
},
{
'target_name': 'icui18n',
'type': 'none',
'toolsets': [ 'host', 'target' ],
},
],
}

0 comments on commit 84f0964

Please sign in to comment.