From 82afb4cf7deab68f22518000a3c2305e7bdc7047 Mon Sep 17 00:00:00 2001 From: sagirk Date: Wed, 23 May 2018 15:50:02 +0530 Subject: [PATCH] test: remove message argument from strictEqual() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). PR-URL: https://github.com/nodejs/node/pull/20912 Fixes: https://github.com/nodejs/node/issues/20911 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat Reviewed-By: Tobias Nießen Reviewed-By: Ujjwal Sharma Reviewed-By: Ruben Bridgewater --- test/parallel/test-require-process.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-require-process.js b/test/parallel/test-require-process.js index f2a3ac89a862fe..57af1508f00a34 100644 --- a/test/parallel/test-require-process.js +++ b/test/parallel/test-require-process.js @@ -3,5 +3,5 @@ require('../common'); const assert = require('assert'); const nativeProcess = require('process'); -assert.strictEqual(nativeProcess, process, - 'require("process") should return global process reference'); +// require('process') should return global process reference +assert.strictEqual(nativeProcess, process);