From 824e8b6f9bfcf0fb24439abfa401e19ecadc4a8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 24 Oct 2019 20:05:57 +0200 Subject: [PATCH] deps: V8: cherry-pick 7228ef8 Original commit message: [objects] Add missing include of isolate-utils.h On Windows with MSVC, compilation fails because it cannot find the GetIsolateForPtrCompr identifier. Change-Id: Ib03f5c5ef34e409242bbbe93ec83b7734012feb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1878712 Reviewed-by: Peter Marshall Commit-Queue: Peter Marshall Cr-Commit-Position: refs/heads/master@{#64551} Refs: https://github.com/v8/v8/commit/7228ef8040785d3237867558b8444422b306c3ce Backport-PR-URL: https://github.com/nodejs/node/pull/30513 PR-URL: https://github.com/nodejs/node/pull/30020 Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina --- common.gypi | 2 +- deps/v8/src/objects/hash-table.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 10b4ecfc52e2fb..78a57d929198be 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.13', + 'v8_embedder_string': '-node.14', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/objects/hash-table.h b/deps/v8/src/objects/hash-table.h index 54d8ce0d2ae18b..ed2c645f82e52b 100644 --- a/deps/v8/src/objects/hash-table.h +++ b/deps/v8/src/objects/hash-table.h @@ -9,6 +9,7 @@ #include "src/base/export-template.h" #include "src/base/macros.h" #include "src/common/globals.h" +#include "src/execution/isolate-utils.h" #include "src/objects/fixed-array.h" #include "src/objects/smi.h" #include "src/roots/roots.h"