crypto: improve GetECGroupBits signature

Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: #53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jun 20, 2024 · 82092cd · 82092cd
1 parent 63f62d7
commit 82092cd
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
@@ -441,10 +441,7 @@ MaybeLocal<Value> GetECPubKey(
       nullptr).FromMaybe(Local<Object>());
 }
 
-MaybeLocal<Value> GetECGroup(
-    Environment* env,
-    const EC_GROUP* group,
-    const ECPointer& ec) {
+MaybeLocal<Value> GetECGroupBits(Environment* env, const EC_GROUP* group) {
   if (group == nullptr)
     return Undefined(env->isolate());
 
@@ -1324,14 +1321,10 @@ MaybeLocal<Object> X509ToObject(
   } else if (ec) {
     const EC_GROUP* group = EC_KEY_get0_group(ec.get());
 
-    if (!Set<Value>(context,
-                    info,
-                    env->bits_string(),
-                    GetECGroup(env, group, ec)) ||
-        !Set<Value>(context,
-                    info,
-                    env->pubkey_string(),
-                    GetECPubKey(env, group, ec))) {
+    if (!Set<Value>(
+            context, info, env->bits_string(), GetECGroupBits(env, group)) ||
+        !Set<Value>(
+            context, info, env->pubkey_string(), GetECPubKey(env, group, ec))) {
       return MaybeLocal<Object>();
     }