benchmark: (streams) use destructuring

PR-URL: #18250 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 30, 2018 · 81abea5 · 81abea5
1 parent 11d6458
commit 81abea5
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 16 deletions.
diff --git a/benchmark/streams/readable-bigread.js b/benchmark/streams/readable-bigread.js
@@ -7,8 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [100e1]
 });
 
-function main(conf) {
-  const n = +conf.n;
+function main({ n }) {
   const b = new Buffer(32);
   const s = new Readable();
   function noop() {}

diff --git a/benchmark/streams/readable-bigunevenread.js b/benchmark/streams/readable-bigunevenread.js
@@ -7,8 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [100e1]
 });
 
-function main(conf) {
-  const n = +conf.n;
+function main({ n }) {
   const b = new Buffer(32);
   const s = new Readable();
   function noop() {}

diff --git a/benchmark/streams/readable-boundaryread.js b/benchmark/streams/readable-boundaryread.js
@@ -8,11 +8,10 @@ const bench = common.createBenchmark(main, {
   type: ['string', 'buffer']
 });
 
-function main(conf) {
-  const n = +conf.n;
+function main({ n, type }) {
   const s = new Readable();
   var data = 'a'.repeat(32);
-  if (conf.type === 'buffer')
+  if (type === 'buffer')
     data = Buffer.from(data);
   s._read = function() {};
 

diff --git a/benchmark/streams/readable-readall.js b/benchmark/streams/readable-readall.js
@@ -7,8 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [50e2]
 });
 
-function main(conf) {
-  const n = +conf.n;
+function main({ n }) {
   const b = new Buffer(32);
   const s = new Readable();
   function noop() {}

diff --git a/benchmark/streams/readable-unevenread.js b/benchmark/streams/readable-unevenread.js
@@ -7,8 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [100e1]
 });
 
-function main(conf) {
-  const n = +conf.n;
+function main({ n }) {
   const b = new Buffer(32);
   const s = new Readable();
   function noop() {}

diff --git a/benchmark/streams/transform-creation.js b/benchmark/streams/transform-creation.js
@@ -13,9 +13,7 @@ function MyTransform() {
 inherits(MyTransform, Transform);
 MyTransform.prototype._transform = function() {};
 
-function main(conf) {
-  const n = +conf.n;
-
+function main({ n }) {
   bench.start();
   for (var i = 0; i < n; ++i)
     new MyTransform();

diff --git a/benchmark/streams/writable-manywrites.js b/benchmark/streams/writable-manywrites.js
@@ -7,8 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [2e6]
 });
 
-function main(conf) {
-  const n = +conf.n;
+function main({ n }) {
   const b = Buffer.allocUnsafe(1024);
   const s = new Writable();
   s._write = function(chunk, encoding, cb) {