From 7f55f98a84e80a56bc4369c71217399b97ff6876 Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Tue, 28 Nov 2017 05:46:35 -0600 Subject: [PATCH] src: fix typo in NODE_OPTIONS whitelist The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: https://github.com/nodejs/node/pull/17369 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Jon Moss Reviewed-By: Gibson Fahnestock Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig --- src/node.cc | 2 +- test/parallel/test-cli-node-options.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node.cc b/src/node.cc index 33101dcd79c6e4..7b4b112897b7e8 100644 --- a/src/node.cc +++ b/src/node.cc @@ -3939,7 +3939,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env, "--trace-sync-io", "--no-force-async-hooks-checks", "--trace-events-enabled", - "--trace-events-categories", + "--trace-event-categories", "--track-heap-objects", "--zero-fill-buffers", "--v8-pool-size", diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js index 4febf1ca1bdd1c..85c35508566ff1 100644 --- a/test/parallel/test-cli-node-options.js +++ b/test/parallel/test-cli-node-options.js @@ -23,6 +23,7 @@ expect('--track-heap-objects', 'B\n'); expect('--throw-deprecation', 'B\n'); expect('--zero-fill-buffers', 'B\n'); expect('--v8-pool-size=10', 'B\n'); +expect('--trace-event-categories node', 'B\n'); if (common.hasCrypto) { expect('--use-openssl-ca', 'B\n');