Skip to content

Commit

Permalink
build: fix test failures not failing Travis builds
Browse files Browse the repository at this point in the history
The exit code of the make command used to execute tests was being lost
after being piped through to grep.

PR-URL: #27176
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
  • Loading branch information
richardlau committed Apr 12, 2019
1 parent 25df3c1 commit 7b0d867
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,5 @@ jobs:
- make -j2 > /dev/null
- make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null
script:
- set -o pipefail
- JOBS=2 FLAKY_TESTS=dontcare make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v

0 comments on commit 7b0d867

Please sign in to comment.