fs: fix writev empty array error behavior

PR-URL: #41919 Fixes: #41910 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
nodejs · Feb 21, 2022 · 7b01a37 · 7b01a37
1 parent 529686e
commit 7b01a37
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -596,6 +596,10 @@ async function writev(handle, buffers, position) {
   if (typeof position !== 'number')
     position = null;
 
+  if (buffers.length === 0) {
+    return { bytesWritten: 0, buffers };
+  }
+
   const bytesWritten = (await binding.writeBuffers(handle.fd, buffers, position,
                                                    kUsePromises)) || 0;
   return { bytesWritten, buffers };

diff --git a/test/parallel/test-fs-writev-promises.js b/test/parallel/test-fs-writev-promises.js
@@ -47,4 +47,13 @@ tmpdir.refresh();
     assert(Buffer.concat(bufferArr).equals(await fs.readFile(filename)));
     handle.close();
   }
+
+  {
+    // Writev with empty array behavior
+    const handle = await fs.open(getFileName(), 'w');
+    const result = await handle.writev([]);
+    assert.strictEqual(result.bytesWritten, 0);
+    assert.strictEqual(result.buffers.length, 0);
+    handle.close();
+  }
 })().then(common.mustCall());