buffer: correct indexOf() error message

PR-URL: #29217 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Sep 4, 2019 · 71aaf59 · 71aaf59
1 parent c900762
commit 71aaf59
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -907,7 +907,7 @@ function bidirectionalIndexOf(buffer, val, byteOffset, encoding, dir) {
   }
 
   throw new ERR_INVALID_ARG_TYPE(
-    'value', ['string', 'Buffer', 'Uint8Array'], val
+    'value', ['number', 'string', 'Buffer', 'Uint8Array'], val
   );
 }
 

diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -22,6 +22,7 @@ const expectedModules = new Set([
   'Internal Binding native_module',
   'Internal Binding options',
   'Internal Binding process_methods',
+  'Internal Binding string_decoder',
   'Internal Binding task_queue',
   'Internal Binding timers',
   'Internal Binding trace_events',

diff --git a/test/parallel/test-buffer-includes.js b/test/parallel/test-buffer-includes.js
@@ -282,7 +282,7 @@ for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
     {
       code: 'ERR_INVALID_ARG_TYPE',
       type: TypeError,
-      message: 'The "value" argument must be one of type string, ' +
+      message: 'The "value" argument must be one of type number, string, ' +
                `Buffer, or Uint8Array. Received type ${typeof val}`
     }
   );

diff --git a/test/parallel/test-buffer-indexof.js b/test/parallel/test-buffer-indexof.js
@@ -357,7 +357,7 @@ assert.strictEqual(Buffer.from('aaaaa').indexOf('b', 'ucs2'), -1);
     {
       code: 'ERR_INVALID_ARG_TYPE',
       type: TypeError,
-      message: 'The "value" argument must be one of type string, ' +
+      message: 'The "value" argument must be one of type number, string, ' +
                `Buffer, or Uint8Array. Received type ${typeof val}`
     }
   );
-Original file line number
+Diff line change
@@ Expand Up @@
       }
       throw new ERR_INVALID_ARG_TYPE(
-        'value', ['string', 'Buffer', 'Uint8Array'], val
+        'value', ['number', 'string', 'Buffer', 'Uint8Array'], val
       );
     }
@@ Expand Down @@