events: allow the options argument to be null

Make `EventTarget.prototype.addEventListener()` accept `null` as a valid value for the `options` argument. PR-URL: #39486 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
nodejs · Jul 29, 2021 · 6f2989c · 6f2989c
1 parent 487c45f
commit 6f2989c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -598,6 +598,9 @@ function shouldAddListener(listener) {
 function validateEventListenerOptions(options) {
   if (typeof options === 'boolean')
     return { capture: options };
+
+  if (options === null)
+    return {};
   validateObject(options, 'options', {
     allowArray: true, allowFunction: true,
   });

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -177,6 +177,15 @@ let asyncTest = Promise.resolve();
   eventTarget.dispatchEvent(event);
 }
 
+{
+  // The `options` argument can be `null`.
+  const eventTarget = new EventTarget();
+  const event = new Event('foo');
+  const fn = common.mustCall((event) => strictEqual(event.type, 'foo'));
+  eventTarget.addEventListener('foo', fn, null);
+  eventTarget.dispatchEvent(event);
+}
+
 {
   const uncaughtException = common.mustCall((err, origin) => {
     strictEqual(err.message, 'boom');