quic: use QuicCallbackScope consistently for QuicSession

PR-URL: #34541 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
nodejs · Aug 3, 2020 · 6e65f26 · 6e65f26
1 parent d96083b
commit 6e65f26
Show file tree

Hide file tree

Showing 2 changed files with 190 additions and 96 deletions.
diff --git a/lib/internal/quic/core.js b/lib/internal/quic/core.js
@@ -2287,12 +2287,11 @@ class QuicServerSession extends QuicSession {
   async [kHandleOcsp](servername) {
     const internalState = this[kInternalState];
     const { context } = this[kInternalServerState];
-    const certificate = context?.context.getCertificate?.();
-    const issuer = context?.context.getIssuer?.();
-    return internalState.ocspHandler?.('request', {
+    if (!internalState.ocspHandler || !context) return undefined;
+    return internalState.ocspHandler('request', {
       servername,
-      certificate,
-      issuer
+      certificate: context.context.getCertificate(),
+      issuer: context.context.getIssuer()
     });
   }