Skip to content

Commit

Permalink
doc: wrap pull-requests.md at 80 characters
Browse files Browse the repository at this point in the history
PR-URL: #21361
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
Trott authored and targos committed Jun 16, 2018
1 parent b8213f1 commit 6c41f33
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ notes about [commit squashing](#commit-squashing)).
A good commit message should describe what changed and why.

1. The first line should:
- contain a short description of the change (preferably 50 characters or less,
and no more than 72 characters)
- contain a short description of the change (preferably 50 characters or
less, and no more than 72 characters)
- be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
- be prefixed with the name of the changed subsystem and start with an
Expand Down Expand Up @@ -456,7 +456,8 @@ Focus first on the most significant aspects of the change:
1. Does this change make sense for Node.js?
2. Does this change make Node.js better, even if only incrementally?
3. Are there clear bugs or larger scale issues that need attending to?
4. Is the commit message readable and correct? If it contains a breaking change is it clear enough?
4. Is the commit message readable and correct? If it contains a breaking change
is it clear enough?

When changes are necessary, *request* them, do not *demand* them, and do not
assume that the submitter already knows how to add a test or run a benchmark.
Expand Down

0 comments on commit 6c41f33

Please sign in to comment.