From 69e775d454a9d2b06a8bafe83ef70b8226c0a8c4 Mon Sep 17 00:00:00 2001 From: Mithun Sasidharan Date: Sun, 3 Dec 2017 23:23:33 +0530 Subject: [PATCH] test: update test-http-timeout to use countdown PR-URL: https://github.com/nodejs/node/pull/17341 Reviewed-By: Jon Moss Reviewed-By: Anatoli Papirovski --- test/parallel/test-http-timeout.js | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/test/parallel/test-http-timeout.js b/test/parallel/test-http-timeout.js index 817bfe7a3c3be7..c576f1c5429101 100644 --- a/test/parallel/test-http-timeout.js +++ b/test/parallel/test-http-timeout.js @@ -23,24 +23,25 @@ require('../common'); const http = require('http'); +const Countdown = require('../common/countdown'); const server = http.createServer(function(req, res) { res.writeHead(200, { 'Content-Type': 'text/plain' }); res.end('OK'); }); +const MAX_COUNT = 11; const agent = new http.Agent({ maxSockets: 1 }); +const countdown = new Countdown(MAX_COUNT, () => server.close()); server.listen(0, function() { - for (let i = 0; i < 11; ++i) { + for (let i = 0; i < MAX_COUNT; ++i) { createRequest().end(); } function callback() {} - let count = 0; - function createRequest() { const req = http.request( { port: server.address().port, path: '/', agent: agent }, @@ -48,11 +49,7 @@ server.listen(0, function() { req.clearTimeout(callback); res.on('end', function() { - count++; - - if (count === 11) { - server.close(); - } + countdown.dec(); }); res.resume();