-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bootstrap: call _undestroy() inside _destroy for stdout and stderr
This change makes `process.stdout` and `process.stderr` to be automatically undestroyed when ended/destrouyed, therefore making it always possible to write/console.log to stdout. Fixes: #39447 PR-URL: #39685 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
- Loading branch information
1 parent
07cadc4
commit 69a2a6b
Showing
2 changed files
with
37 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const spawn = require('child_process').spawn; | ||
|
||
if (process.argv[2] === 'child') { | ||
process.stdout.destroy(); | ||
process.stderr.destroy(); | ||
console.log('stdout'); | ||
process.stdout.write('rocks\n'); | ||
console.error('stderr'); | ||
setTimeout(function() { | ||
process.stderr.write('rocks too\n'); | ||
}, 10); | ||
return; | ||
} | ||
|
||
const proc = spawn(process.execPath, [__filename, 'child'], { stdio: 'pipe' }); | ||
|
||
let stdout = ''; | ||
proc.stdout.setEncoding('utf8'); | ||
proc.stdout.on('data', common.mustCallAtLeast(function(chunk) { | ||
stdout += chunk; | ||
}, 1)); | ||
|
||
let stderr = ''; | ||
proc.stderr.setEncoding('utf8'); | ||
proc.stderr.on('data', common.mustCallAtLeast(function(chunk) { | ||
stderr += chunk; | ||
}, 1)); | ||
|
||
proc.on('exit', common.mustCall(function(exitCode) { | ||
assert.strictEqual(exitCode, 0); | ||
assert.strictEqual(stdout, 'stdout\nrocks\n'); | ||
assert.strictEqual(stderr, 'stderr\nrocks too\n'); | ||
})); |